[Cython] ref-leak in 0.17

Robert Bradshaw robertwb at gmail.com
Wed Sep 26 10:10:33 CEST 2012


On Wed, Sep 26, 2012 at 12:28 AM, Stefan Behnel <stefan_ml at behnel.de> wrote:
> mark florisson, 25.09.2012 22:37:
>>>> On 25 September 2012 16:12, Stefan Behnel wrote:
>>>>> Stefan Behnel, 25.09.2012 14:55:
>>>>>> there is a reference leak in the new dict iteration code in 0.17:
>>>>>>
>>>>>> http://trac.cython.org/cython_trac/ticket/790
>>>>>>
>>>>>> I'll see if I can fix it and then release a pure bugfix 0.17.1 right
>>>>>> afterwards.
>>>>>>
>>>>>> Please take a look at your own patch queues to see if there are any other
>>>>>> important bugs that you would like to see fixed in that release.
>>>>>
>>>>> Update: I fixed this, so 0.17.1 will be released tomorrow (CEST) unless
>>>>> you've thrown in your veto by then.
>>
>> We only have a few really small fixes, do we really want to push
>> out a bugfix release with this?
>
> My answer is Yes. The dict iteration regression breaks lxml really badly
> and I'm sure code of other people is impacted, too. Remember that ref-leaks
> are way less obvious than crashes and usually won't show in test suites. It
> took me quite a while to get to the source of this problem.
>
> Besides, it's been almost a month since the release and if nothing else
> piled up since then, the better.

Also, on a more general note, I would rather err towards more small
bugfix releases (when impactful bugs come up) instead of the pattern
we've fallen into of only releasing a couple times a year. So +1 to
this.

- Robert


More information about the cython-devel mailing list