[Csv] Re: [Python-checkins] python/nondist/sandbox/csv _csv.c,1.9,1.10

[Dave Cole]

>>>>> "Skip" == Skip Montanaro <skip at pobox.com> writes:

dave> Oops - forgot to check for '+-.' when quoting is
dave> QUOTE_NONNUMERIC.

Skip> Looking at the code, I wonder if when quoting is set to
Skip> NONNUMERIC a single attempt to call PyFloat_FromString(field)
Skip> should be made and the result used to identify the field as
Skip> numeric or not.  (Not for performance, but for accuracy of the
Skip> setting.)

You are probably right.  The current code is completely ignorant of
locale settings.

- Dave

-- 
http://www.object-craft.com.au