[C++-sig] Patch implementing void * support

David Abrahams dave at boost-consulting.com
Thu Jan 26 18:20:47 CET 2006


"Niall Douglas" <s_sourceforge at nedprod.com> writes:

> On 26 Jan 2006 at 11:43, David Abrahams wrote:
>
>> > Anyway, it's attached working on GCC 4.0.2 and MSVC 6.0 and 7.1.
>> 
>> So these workarounds that are guarded by
>> 
>>   #ifdef BOOST_MSVC
>> 
>> Are known to be needed on vc7.1 as well as vc6?  What about vc8?
>> You ought to be using BOOST_WORKAROUND here.
>
> I copied exactly the code at the end of opaque_pointer_converter.hpp. 
> It uses #ifdef BOOST_MSVC, so I reused exactly the same form in 
> type_id.hpp.

I didn't write that code; I probably should never have approved it in
that form.

> If opaque_pointer_converter.hpp should be different, then so should 
> type_id.hpp. 

Sure.

> I don't know whether it should be different for msvc7.1 -
>  whoever wrote opaque_pointer_converter.hpp is better suited to 
> answer that question.
>
> The only reason type_id.hpp needed a separate declaration is because
> GCC complained about adding template specialisations after they have
> been instanced. It's probably a good thing.

Hyah.

But give me a patch that works, please.

-- 
Dave Abrahams
Boost Consulting
www.boost-consulting.com




More information about the Cplusplus-sig mailing list